radareorg / radare2-bindings

Bindings of the r2 api for Valabind and friends
GNU Lesser General Public License v3.0
130 stars 92 forks source link

QA Notice: Files built without respecting CFLAGS have been detected #154

Closed blshkv closed 7 years ago

blshkv commented 7 years ago
 *  Please include the following list of files in your report:
 * /usr/lib64/perl5/vendor_perl/5.22.3/x86_64-linux/r2/r_asm.so
 * /usr/lib64/perl5/vendor_perl/5.22.3/x86_64-linux/r2/r_bin.so
 * /usr/lib64/perl5/vendor_perl/5.22.3/x86_64-linux/r2/r_core.so
 * /usr/lib64/radare2/1.3.0/lang_csharp.so
 * /usr/lib64/python2.7/site-packages/r2/_r_core.so
 * /usr/lib64/python2.7/site-packages/r2/_r_bin.so
 * /usr/lib64/python2.7/site-packages/r2/_r_asm.so
blshkv commented 7 years ago

Here is how we fixed it in capstone: https://github.com/aquynh/capstone/issues/57

radare commented 7 years ago

this seems like a problem in valabind, not the bindings

On 11 Apr 2017, at 01:01, Anton Bolshakov notifications@github.com wrote:

Here is how we fixed it in capstone: aquynh/capstone#57 https://github.com/aquynh/capstone/issues/57 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/radare/radare2-bindings/issues/154#issuecomment-293103114, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lo0SApecYkMLvIezYfA5CUyktExwks5rurS2gaJpZM4M5bBa.

blshkv commented 7 years ago

can you fix either of them? I have tried to compile with the latest valabind v1.3.0 and facing the same issue.

radare commented 7 years ago

btw, those are c++ files, are you talking about CFLAGS or CXXFLAGS? or share a build log or the env vars you expect to be exposed to the compiler and dont happen?

radare commented 7 years ago

also, valabind trims out some cflags in purpose because python-config shows sometimes some cflags and ldflags that are just breaking the build

radare commented 7 years ago

(see my last commit in the valabind repo)

blshkv commented 7 years ago

well done, I have applied the patch and the warning is gone. Thanks!

radare commented 7 years ago

Cool that my blindfix solved the issue. Ill do a new release of valabind

Thanks

On 11 Aug 2017, at 03:08, Anton Bolshakov notifications@github.com wrote:

well done, I have applied the patch and the warning is gone. Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.