search

radareorg / radare2-bindings

Bindings of the r2 api for Valabind and friends
GNU Lesser General Public License v3.0
131 stars 92 forks source link

Fix Makefile install-python for macOS #158

Closed makigumo closed 7 years ago

makigumo commented 7 years ago

fixes #157

radare commented 7 years ago

Really? Is python finally looking for .dylib instead of .so in mac? This fucks hard backward compat with old versions of python but if so we can just go forward and tell everyone to update :p

On 30 Apr 2017, at 13:55, makigumo notifications@github.com wrote:

fixes #157

You can view, comment on, or merge this pull request online at:

https://github.com/radare/radare2-bindings/pull/158

Commit Summary

Fix Makefile install-python for macOS File Changes

M Makefile (8) Patch Links:

https://github.com/radare/radare2-bindings/pull/158.patch https://github.com/radare/radare2-bindings/pull/158.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

makigumo commented 7 years ago

I don't know if python is looking for .dylib or .so, but this patch is trying to fix that the Makefile is looking for .so files to copy when on macOS .dylib files are built. Which is breaking the build with an error message cp: *.so: No such file or directory. If you are implying that the built files on macOS should not have the .dylib ending but the .so ending and thus should be renamed, then this is not a valid fix.

radare commented 7 years ago

yes, python on mac and windows load .so files, not .dll or .dylib files. so this pr will break the bindings

On 02 May 2017, at 16:04, makigumo notifications@github.com wrote:

I don't know if python is looking for .dylib or .so, but this patch is trying to fix that the Makefile is looking for .so files to copy when on macOS .dylib files are built. Which is breaking the build with an error message cp: *.so: No such file or directory. If you are implying that the built files on macOS should not have the .dylib ending but the .so ending and thus should be renamed, then this is not a valid fix.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/radare2-bindings/pull/158#issuecomment-298645398, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lg4IfLMFXKmDSi0--mzk6AsQC0Tjks5r1zgKgaJpZM4NMjF0.

radare commented 7 years ago

(didnt tried yet)

On 02 May 2017, at 16:04, makigumo notifications@github.com wrote:

I don't know if python is looking for .dylib or .so, but this patch is trying to fix that the Makefile is looking for .so files to copy when on macOS .dylib files are built. Which is breaking the build with an error message cp: *.so: No such file or directory. If you are implying that the built files on macOS should not have the .dylib ending but the .so ending and thus should be renamed, then this is not a valid fix.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/radare2-bindings/pull/158#issuecomment-298645398, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lg4IfLMFXKmDSi0--mzk6AsQC0Tjks5r1zgKgaJpZM4NMjF0.

marcograss commented 7 years ago

I tried this pull request + renaming manually .dylib to .so once installed

after those 2 steps I can import in python successfully

radare commented 7 years ago

Fixed in master, this patch is not correct. confirmed by @marcograss