add C plugin skeletons to be referenced in r2book

radareorg / radare2-bindings

Bindings of the r2 api for Valabind and friends

GNU Lesser General Public License v3.0

131 stars 92 forks source link

add C plugin skeletons to be referenced in r2book #195

Closed Wenzel closed 5 years ago

Wenzel commented 6 years ago

This PR adds a folder to add C plugin skeletons.

The only skeleton available is a debug plugin for now. It will help people write plugins, and the skeletons should be referenced in the r2book

radare commented 6 years ago

Are those skeletons going to be updated when something changes in core? If not we have a maintainance problem

Wenzel commented 6 years ago

A few questions:

how frequent the plugins interface has been changed in the past ?
it's better to have broken skeleton with compilation issues on the latest radare than nothing in my opinion. It helps get people started.
we could raise the awareness of these skeletons to the devs working on core, so that they will update these skeletons too if they have to break the interface one day.

radare commented 5 years ago

What do you think @XVilka ?

We have a bunch of simple plugins to demonstrate how to write plugins already. the skel can be tested by building it and fail if any warning is spit.

the amount of changes depend on the contributions and time, so its not that much because most prs are about bug fixes, new features or small refactorings, but not really heavy changes in debug yet, we are focusing in rbin now.

i can merge, but i want to be sure that we can test this properly, so we get notified by travis when it gets broken

radare commented 5 years ago

i think those skeletons should be automatically generated from the headers instead of maintained by hand. i think we should close this PR