search

radareorg / radare2-bindings

Bindings of the r2 api for Valabind and friends
GNU Lesser General Public License v3.0
130 stars 92 forks source link

Drop python2 support #214

Closed aronsky closed 5 years ago

aronsky commented 5 years ago

As per #206, remove Python 2 support.

Note: I haven't completely tested the win32 compilation on Wine. I updated the download to use the latest Python 3 available as an MSI package (since later Python 3 versions fail to install successfully under Wine), but make fails due to other errors that I didn't feel like diving into. If anyone knows how the build of the w32 Python bindings works and can test its functionality, that'll be great.

XVilka commented 5 years ago

I also think we should drop everything that older 3.6: https://repology.org/project/python3/versions

aronsky commented 5 years ago

I also think we should drop everything that older 3.6: https://repology.org/project/python3/versions

I'm all for newer versions, but dropping older versions of Python 3 seems unnecessary - the only difference is the call to Py_Finalize (which is void before 3.6), that's easy to maintain... And if the wine build works, it's a lot easier to build with Python 3.4 (which can be installed under wine without problems), than newer versions (which aren't distributed in MSI packaging, and their installation fails).

aronsky commented 5 years ago

The latest commit now builds lang_python.{so|dylib}, instead of lang_python3.{so|dylib}.

I guess that once this gets merged, we should also update the r2pm repo to include just lang_python, instead of lang_python2 and lang_python3.

However, this switch will require a manual update from an older version of lang_python3 to the new lang_python. Is that OK?

XVilka commented 5 years ago

Yes, I think that's OK. Thank you!

XVilka commented 5 years ago

Merging this to let people test and catch bug early.