Previously, python module would check if filename started with "tcp"
or "http." This would cause weird edge cases where a relative path
starting with a directory called "tcp" or "http" would cause an
exception to be thrown. This checks for filenames that start with
"tcp://" or "http://" instead, which might still cause the same
issue but is less likely.
Test plan
Confirm that this fixes #114 while not breaking existing "tcp" and "http" functionality.
a1ext
commented
4 years ago
Detailed description
Previously, python module would check if filename started with "tcp" or "http." This would cause weird edge cases where a relative path starting with a directory called "tcp" or "http" would cause an exception to be thrown. This checks for filenames that start with "tcp://" or "http://" instead, which might still cause the same issue but is less likely.
Test plan
Confirm that this fixes #114 while not breaking existing "tcp" and "http" functionality.
Open http r2pipe still works: https://asciinema.org/a/mMoiuX7wCc8WWyugLeoiUMDLJ
Open tcp r2pipe doesn't work, but it doesn't work with old version either (will open separate issue maybe): https://asciinema.org/a/LPOQr085xo4qLx6qN3NdetFPO
Show fix to #114: https://asciinema.org/a/hfCV8YcaSPyvwR2ifQHY7VpQr
Closing issues
Closes #114