Closed gcolajan closed 7 years ago
Not ready to merge i guess..
On 12 Dec 2016, at 05:24, Gautier Colajanni notifications@github.com wrote:
Multiples modifications to handle ES6 + modules.
Important: Require to support seek() before merge!
You can view, comment on, or merge this pull request online at:
https://github.com/radare/radare2-webui/pull/129
Commit Summary
Add babel transpiler (ES2015) Fix "use strict" Fix warning on user-scalable Fix gulp logic Add tests and eslint Fix "test" target as "tests" Moving index.js content into dedicated places Move file in logical tree, add src map for debug Refactoring of panels for ES6 Add capacity to format offsets as node File Changes
M CONTRIBUTING.md (12) A www/m/.eslintrc (17) D www/m/.jscsrc (35) A www/m/CONTRIBUTING.md (50) M www/m/Makefile (9) M www/m/bower.json (2) M www/m/css/autocomplete.css (18) M www/m/css/disasm.css (10) M www/m/css/flexcontainer.css (2) A www/m/css/material-design-icons.css (13) A www/m/css/overview.css (5) A www/m/css/tables.css (3) M www/m/gulpfile.js (252) M www/m/index.html (69) A www/m/js/app.js (121) D www/m/js/autocomplete.js (215) D www/m/js/blocknavigator.js (172) D www/m/js/container_zone.js (283) A www/m/js/core/ChunkStatus.js (4) A www/m/js/core/NavigatorDirection.js (5) A www/m/js/core/R2Wrapper.js (134) A www/m/js/core/SettingsManager.js (61) A www/m/js/core/UIContext.js (34) A www/m/js/core/blocknavigator.js (168) R www/m/js/dialogs/dialog_networkerr.legacy.js (0) A www/m/js/disasm/Disassembly.js (832) A www/m/js/disasm/DisassemblyNavigator.js (280) D www/m/js/disasm/disasm.js (527) D www/m/js/disasm/disasm_auxDraw.js (279) D www/m/js/disasm/disasmnavigator.js (276) A www/m/js/helpers/Format.js (25) A www/m/js/helpers/Inputs.js (58) A www/m/js/helpers/Speak.js (29) A www/m/js/helpers/UpdateManager.js (22) R www/m/js/helpers/action_listener.legacy.js (0) A www/m/js/helpers/project_management.legacy.js (13) A www/m/js/helpers/prompts.legacy.js (58) R www/m/js/helpers/tools.legacy.js (1) R www/m/js/helpers/ui.legacy.js (0) R www/m/js/helpers/uiTables.legacy.js (9) A www/m/js/hexdump/WordSizes.js (7)
M www/m/js/hexdump/hexdump.js (1472) D www/m/js/hexdump/hexdump_auxDraw.js (443) D www/m/js/hexdump/hexdump_flag.js (140) D www/m/js/hexdump/hexdump_mainDraw.js (433) M www/m/js/hexdump/hexpairnavigator.js (317) R www/m/js/hexdump/tools.legacy.js (0) D www/m/js/index.js (831) A www/m/js/overview/AnalysisCard.js (107) A www/m/js/overview/EntropyCard.js (87) A www/m/js/overview/FortunesCard.js (54) A www/m/js/overview/GraphCard.js (85) A www/m/js/overview/InfoCard.js (163)
A www/m/js/overview/Overview.js (60)
D www/m/js/radare_infinite_block.js (62) D www/m/js/update_manager.js (19) D www/m/js/widget.js (51) A www/m/js/widgets/Autocompletion.js (219) A www/m/js/widgets/ContainerLayout.js (5) A www/m/js/widgets/ContainerZone.js (292) A www/m/js/widgets/GlobalContext.rm.js (25) A www/m/js/widgets/RadareInfiniteBlock.js (61) M www/m/js/widgets/flexContainer.js (195) M www/m/js/widgets/infiniteScrolling.js (91) D www/m/js/widgets/panelComments.js (38) D www/m/js/widgets/panelDisasm.js (27) D www/m/js/widgets/panelHexdump.js (35) D www/m/js/widgets/panelOverview.js (305) D www/m/js/widgets/panelSettings.js (271) A www/m/js/widgets/panels/BasePanel.js (45) A www/m/js/widgets/panels/BasePrePanel.js (48) A www/m/js/widgets/panels/CommentsPanel.js (69) A www/m/js/widgets/panels/DebuggerPanel.js (73) A www/m/js/widgets/panels/DisassemblyBlocksPanel.js (18) A www/m/js/widgets/panels/DisassemblyDecompilePanel.js (18) A www/m/js/widgets/panels/DisassemblyFunctionsFullPanel.js (18) A www/m/js/widgets/panels/DisassemblyFunctionsPanel.js (18) A www/m/js/widgets/panels/DisassemblyGraphPanel.js (48) A www/m/js/widgets/panels/DisassemblyInfosPanel.js (18) A www/m/js/widgets/panels/DisassemblyPanel.js (39) A www/m/js/widgets/panels/FlagsPanel.js (63) A www/m/js/widgets/panels/FlagsSpacesPanel.js (125) A www/m/js/widgets/panels/FunctionsPanel.js (95) A www/m/js/widgets/panels/HexdumpPanel.js (39) A www/m/js/widgets/panels/NotesPanel.js (42) A www/m/js/widgets/panels/OverviewPanel.js (23) A www/m/js/widgets/panels/PanelFactory.js (103) A www/m/js/widgets/panels/Panels.js (20) A www/m/js/widgets/panels/ScriptPanel.js (94) A www/m/js/widgets/panels/SearchPanel.js (115) A www/m/js/widgets/panels/SettingsPanel.js (167) R www/m/js/widgets/statusbar/console.legacy.js (55) R www/m/js/widgets/statusbar/statusbar.legacy.js (12) A www/m/js/widgets/widget.js (55) M www/m/package.json (35) A www/m/test/index.html (33) A www/m/test/specs/helpers/chai.js (13) A www/m/test/test.test.js (16) Patch Links:https://github.com/radare/radare2-webui/pull/129.patch https://github.com/radare/radare2-webui/pull/129.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
This version convert the majority of files to ES6 syntax with classes and import/export. It shouldn't break anything that was working before. I've introduced some changes inside the UI (access to buttons)
Conversion to ES6 is almost complete, last files named as legacy need to be refactored at deeper level (nothing big).
It also fix: #104 #127 #93
From my point of view, ready to be merged.
Awesome! nice refactoring
Multiples modifications to handle ES6 + modules.
Important: Require to support seek() before merge!