radareorg / radare2

UNIX-like reverse engineering framework and command-line toolset
https://www.radare.org/
GNU Lesser General Public License v3.0
20.64k stars 3k forks source link

Change behaviour for search instruction with '/c' command #10720

Open dukebarman opened 6 years ago

dukebarman commented 6 years ago

This template is meant for bug reports, if you have a feature request, please be as descriptive as possible and delete the template

Make sure you are testing using the latest git version of radare2 before submitting any issue.

If you would like to report a bug, please fill the template bellow

Work environment

Questions Answers
OS/arch/bits (mandatory) OSX \ Windows \ Linux
r2 -v full output, not truncated (mandatory) radare2 2.8.0-git 18935 @ darwin-x86-64 git.2.7.0-24-gd3a3940d7 commit: d3a3940d75a2d1abdb78031eb9a43482a657f5ac build: 2018-07-12__17:46:48

Expected behavior

r2 searches instructions only in disasm with /c command

Actual behavior

r2 searches instructions byte per byte with /c command (it's /ca behaviour) and break Visual mode with hits* inserts in wrong places

Steps to reproduce the behavior

$ r2 /bin/ls
[0x100001200]> Vp # check view
[0x100001200]>/c mov
[0x100001200]> Vp # check after search

Additional Logs, screenshots, source-code, configuration dump, ...

Normal disasm view screen shot 2018-07-12 at 5 53 28 pm

After try to search /c mov screen shot 2018-07-12 at 5 53 48 pm

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. Considering a lot has changed since its creation, we kindly ask you to check again if the issue you reported is still relevant in the current version of radare2. If it is, update this issue with a comment, otherwise it will be automatically closed if no further activity occurs. Thank you for your contributions.