Closed l2dy closed 6 years ago
Sorry, I made a typo. The regression happened after 2.8.0.
git bisect: 1262027b722cad4f574ef704e6a4eac35f316a42 is the first bad commit
Can you share the project files too?
On 15 Aug 2018, at 15:35, Zero King notifications@github.com wrote:
git bisect: 1262027 is the first bad commit
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
@radare I don't have time for that today (didn't save the projects separately during bisect), maybe tomorrow.
Is it still slow?
I have recently two commits to optimize this
% time (repeat 10 ~/Dev/Bin/radare2/release/binr/radare2/radare2 -p t1 -c '' -Q a.out)
=> 0.749 total
git bisect shows that since 6d115eac58a83db27f8550475c37aece903fedaf the situation improved, but it's still slower than 2.7.0.
real 0m1.884s
user 0m1.560s
sys 0m0.285s
Can you dump a diff of the project rc files? (Mine is at ~/.local/share/radare2/projects/t1/rc
)
It is possible that the latest one is loading/dumping more information.
Here it is the reason:
On 24 Aug 2018, at 09:08, Zero King notifications@github.com wrote:
Diff of rc files — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@radare What reason? I can't find anything meaningful in your comment.
dont u see the diff?
i fixed the dumping of metadata,before some type information was saved as (…) …. which is obviously not a valid r2 command, and now it is using C* ones. so thats why it slower. because now it does more stuff
On 24 Aug 2018, at 13:18, Zero King notifications@github.com wrote:
@radare https://github.com/radare What reason? I can't find anything meaningful in your comment.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/11096#issuecomment-415729907, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-ljAoMcUiBncM7J-4LGJjSAiu5o6Hks5uT-EEgaJpZM4V9W8s.
Thanks for the explanation. But in 2.7.0 loading a project is faster than analyzing from scratch, while the latest git version (10265a050728fc530f5272b138aec17fb0e9fbf7) makes it about 3 times slower than analyzing. Even if it's caused by the three Ct commands, I think something is going wrong here…
I'm using projects to shorten the time needed to get a running r2 with an analyzed binary. This regression defeated my purpose using it.
real 0m0.557s
user 0m0.252s
sys 0m0.197s
real 0m1.629s
user 0m1.434s
sys 0m0.118s
P.S. The three (...)
lines were added after 2.7.0. (Not sure if this helps.)
Projects need a huge overhaul, i have lot of plans for them , but they are pretty low in my priority list.
We should save the metadata in SDB instead of commands, this will make loading projects MUCH faster because it will be just 1 mmap call and not over 9000 reads, string parsings and command executions.
This will probably solve this loading time issue.
you can also see the prj. eval variables and see if prj.simple works better for you.
On 24 Aug 2018, at 16:33, Zero King notifications@github.com wrote:
Thanks for the explanation. But in 2.7.0 loading a project is faster than analyzing from scratch, while the latest git version (10265a0 https://github.com/radare/radare2/commit/10265a050728fc530f5272b138aec17fb0e9fbf7) makes it about 3 times slower than analyzing. Even if it's caused by the three Ct commands, I think something is going wrong here…
I'm using projects to shorten the time needed to get a running r2 with an analyzed binary. This regression defeated my purpose using it.
Analyzing a binary
real 0m0.557s user 0m0.252s sys 0m0.197s Loading the project
real 0m1.629s user 0m1.434s sys 0m0.118s P.S. The three (...) lines were added after 2.7.0. (Not sure if this helps.)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/11096#issuecomment-415777679, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lqDLhsVzDO9nH0iwh3N7I3mqZwvzks5uUA7CgaJpZM4V9W8s.
prj.simple
doesn't help (makes it slower). Thanks anyway!
Work environment
Built with MacPorts, commit a095f6f3f0e68bc0a48eb22560c1d5f00a40f355.
Expected behavior
Loading from a project is faster than analyzing from scratch.
r2 2.7.0
Actual behavior
Loading the project takes much longer.
r2 a095f6f3f0e68bc0a48eb22560c1d5f00a40f355
Steps to reproduce the behavior
CODE
to make your code visibleAdditional Logs, screenshots, source-code, configuration dump, ...
Drag and drop zip archives containing the Additional info here, don't use external services or link.