Revise ps and kill r_str_utf16_encode()

[thestr4ng3r]

r_str_utf16_encode() looks very wrong to me. All it does is go through the string byte by byte and print non-printable bytes as \u00xx, which is nonsense, because it corresponds to no real encoding and especially not to utf-16.

This function is especially used in some ps commands, in particular psu, which I have no idea what purpose it should have. If you know, please tell me.

Also, from just quickly looking at r_print_string(), I think there is a lot wrong here too. The seek parameter is not used at all and if R_PRINT_STRING_WIDE is passed, the only difference is that every second byte is skipped. What kind of an encoding is that supposed to be?

For ps, I would suggest a command format like ag has. I.e. you have multiple commands that read strings with different encodings and print it in different formats, for example:

psr[format]    print raw string (just interpret bytes as unicode indices)
psu[format]    print utf-8 string
psw[format]    print utf-16 string
psW[format]    print utf-32 string
...

Output formats:
<blank>    utf-8
j          json
...

So this means for example psw will READ a zero-terminated utf-16 string from the current seek and PRINT it as utf-8. For non-zero terminated strings, one could for example pass the size as an arg.

[thestr4ng3r]

Btw, for cases where data should be printed to json without clear awareness of the encoding, r_str_utf16_encode() should be replaced by base64.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Considering a lot has changed since its creation, we kindly ask you to check again if the issue you reported is still relevant in the current version of radare2. If it is, update this issue with a comment, otherwise it will be automatically closed if no further activity occurs. Thank you for your contributions.