radareorg / radare2

UNIX-like reverse engineering framework and command-line toolset
https://www.radare.org/
GNU Lesser General Public License v3.0
20.63k stars 3k forks source link

Text of errors deteles info text of radare2 #12784

Open dukebarman opened 5 years ago

dukebarman commented 5 years ago

Work environment

Questions Answers
OS/arch/bits (mandatory) any
File format of the file you reverse (mandatory) any
Architecture/bits of the file (mandatory) any
r2 -v full output, not truncated (mandatory) radare2 3.3.0-git 20776 @ darwin-x86-64 git.3.2.0-72-gea92c06e1 commit: ea92c06e1ac1df8ce7e087ab392cb6a1bc5bebbc build: 2019-01-14__14:42:50

Expected behavior

$ r2 /bin/ls
 -- There is only one binary, and we are all just reversing pieces of it.
[0x1000011ec]> aaa
[x] Analyze all flags starting with sym. and entry0 (aa)
Invalid instruction of 16357 bytes at 0x100001a100
Invalid instruction of 16369 bytes at 0x100001ddc
Invalid instruction of 16362 bytes at 0x100001ddc
[x] Analyze function calls (aac)
[x] Analyze len bytes of instructions for references (aar)
[x] Constructing a function name for fcn.* and sym.func.* functions (aan)
[x] Type matching analysis for all functions (aaft)
[x] Use -AA or aaaa to perform additional experimental analysis.
[0x1000011ec]>

Actual behavior

$ r2 /bin/ls
 -- There is only one binary, and we are all just reversing pieces of it.
[0x1000011ec]> aaa
[Invalid instruction of 16357 bytes at 0x100001a100 (aa)
Invalid instruction of 16369 bytes at 0x100001ddc
Invalid instruction of 16362 bytes at 0x100001ddc
[x] Analyze all flags starting with sym. and entry0 (aa)
[x] Analyze function calls (aac)
[x] Analyze len bytes of instructions for references (aar)
[x] Constructing a function name for fcn.* and sym.func.* functions (aan)
[x] Type matching analysis for all functions (aaft)
[x] Use -AA or aaaa to perform additional experimental analysis.
[0x1000011ec]>

Steps to reproduce the behavior

Open any binary with errors

Additional files

ls.zip - standard /bin/ls from MacOS 10.14

radare commented 5 years ago

thats debugging messages for us to h elp us identify bugs in the analysis loop and improve them, could you check whats in those offsets? also git pull be ause i solved some false positives yesterday

On 14 Jan 2019, at 17:59, Boris Ryutin notifications@github.com wrote:

Work environment

Questions Answers OS/arch/bits (mandatory) any File format of the file you reverse (mandatory) any Architecture/bits of the file (mandatory) any r2 -v full output, not truncated (mandatory) radare2 3.3.0-git 20776 @ darwin-x86-64 git.3.2.0-72-gea92c06e1 commit: ea92c06 https://github.com/radare/radare2/commit/ea92c06e1ac1df8ce7e087ab392cb6a1bc5bebbc build: 2019-01-14__14:42:50 Expected behavior

$ r2 /bin/ls -- There is only one binary, and we are all just reversing pieces of it. [0x1000011ec]> aaa [x] Analyze all flags starting with sym. and entry0 (aa) Invalid instruction of 16357 bytes at 0x100001a100 Invalid instruction of 16369 bytes at 0x100001ddc Invalid instruction of 16362 bytes at 0x100001ddc [x] Analyze function calls (aac) [x] Analyze len bytes of instructions for references (aar) [x] Constructing a function name for fcn. and sym.func. functions (aan) [x] Type matching analysis for all functions (aaft) [x] Use -AA or aaaa to perform additional experimental analysis. [0x1000011ec]> Actual behavior

$ r2 /bin/ls -- There is only one binary, and we are all just reversing pieces of it. [0x1000011ec]> aaa [Invalid instruction of 16357 bytes at 0x100001a100 (aa) Invalid instruction of 16369 bytes at 0x100001ddc Invalid instruction of 16362 bytes at 0x100001ddc [x] Analyze all flags starting with sym. and entry0 (aa) [x] Analyze function calls (aac) [x] Analyze len bytes of instructions for references (aar) [x] Constructing a function name for fcn. and sym.func. functions (aan) [x] Type matching analysis for all functions (aaft) [x] Use -AA or aaaa to perform additional experimental analysis. [0x1000011ec]> Steps to reproduce the behavior

Open any binary with errors

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/12784, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lmEG-ydzQypzT1u5BpF24BAGahyjks5vDLdXgaJpZM4Z-67T.

dukebarman commented 5 years ago

I understand it, but this issue about that error messages corrupt normal informational messages from radare2 by overlapping them.

[Invalid instruction of 16357 bytes at 0x100001a100 (aa)
radare commented 5 years ago

thats how \r works

On 17 Jan 2019, at 11:29, Boris Ryutin notifications@github.com wrote:

I understand it, but this issue about that error messages corrupt normal informational messages from radare2 by overlapping them.

[Invalid instruction of 16357 bytes at 0x100001a100 (aa) — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/12784#issuecomment-455122326, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lhnyhZ-FZpRk1k2KT6WYh3wxnhZzks5vEFCjgaJpZM4Z-67T.