search

radareorg / radare2

UNIX-like reverse engineering framework and command-line toolset
https://www.radare.org/
GNU Lesser General Public License v3.0
20.68k stars 3k forks source link

SPECIAL_SYM TLDR #13760

Closed radare closed 5 years ago

radare commented 5 years ago

Use 4 letter for this thing in is

IMAGE 2019-04-15 12:44:19

ret2libc commented 5 years ago

I think anything too short would be not understandable by users.

What about SPEC_SYM?

radare commented 5 years ago

then just uses SPEC, all the other keywords are 4 letter, we should stick to something visually consistent or i'll cry again

On 16 Apr 2019, at 16:52, Riccardo Schirone notifications@github.com wrote:

I think anything too short would be not understandable by users.

What about SPEC_SYM?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/13760#issuecomment-483695440, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lqo5oN28MMSGid832BXPfX8VA9z0ks5vheOggaJpZM4cvqmf.

ret2libc commented 5 years ago

they are not all 4. There is also NOTYPE. But ok for SPEC.

radare commented 5 years ago

then SPECIAL or SPCL. because SPEC looks more like specifications

On 17 Apr 2019, at 14:25, Riccardo Schirone notifications@github.com wrote:

they are not all 4. There is also NOTYPE. But ok for SPEC.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/13760#issuecomment-484060976, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lifJRtA8Yu_XzraD3Ag9s8aI6_nbks5vhxLBgaJpZM4cvqmf.

ret2libc commented 5 years ago

SPCL. Done! :D

radare commented 5 years ago

then NOTYPE into NTYP? looks really messed up, more like stocks than a real word

On 17 Apr 2019, at 14:30, Riccardo Schirone notifications@github.com wrote:

SPCL. Done! :D

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/13760#issuecomment-484062430, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-ljwyQgqVSOwoC1n74En_ahe0R9MSks5vhxPqgaJpZM4cvqmf.

ret2libc commented 5 years ago

Mh... NOTYPE is already ok. It is correctly aligned.

radare commented 5 years ago

@ret2libc can you fix this issue? im fine with NOTYPE too