radareorg / radare2

UNIX-like reverse engineering framework and command-line toolset
https://www.radare.org/
GNU Lesser General Public License v3.0
20.57k stars 2.99k forks source link

PowerPC64 ragg2 unimplemented #15468

Open XVilka opened 4 years ago

XVilka commented 4 years ago

2 failing tests for PPC https://travis-ci.com/github/radareorg/radare2/jobs/440528096#L847

[XX] db/tools/ragg2 ragg2 debruijn sequence 2
R2_NOPLUGINS=1 radare2 -escr.utf8=0 -escr.color=0 -escr.interactive=0 -N -Qc '!ragg2 -P 2 -r; ?e' -
-- stdout
@@ -1 +1 @@
-AA
+
-- stderr
r_egg_assemble: invalid assembly

[XX] db/tools/ragg2 ragg2 debruijn sequence 1
R2_NOPLUGINS=1 radare2 -escr.utf8=0 -escr.color=0 -escr.interactive=0 -N -Qc '!ragg2 -r -P 2; ?e' -
-- stdout
@@ -1 +1 @@
-AA
+
-- stderr
r_egg_assemble: invalid assembly
XVilka commented 4 years ago

107 now https://travis-ci.com/radareorg/radare2/jobs/269167852 Many of them just assume x86 arch is set, should be fixed

XVilka commented 4 years ago

Around 80 left

radare commented 4 years ago

yay \o/

radare commented 4 years ago

ive fixed some, now the numbers are:

ARM64 18 PPC64 22 S390X > 1000 newShell 96

see https://github.com/radareorg/radare2/pull/16435

XVilka commented 3 years ago

12 failing tests for PPC now: https://travis-ci.com/github/radareorg/radare2/jobs/423694412#L794

XVilka commented 3 years ago

2 failing tests for PPC now: https://travis-ci.com/github/radareorg/radare2/jobs/440528096#L847

cc @eagleoflqj

XVilka commented 3 years ago

See also build warnings:

p/debug_native.c: In function ‘r_debug_native_bp’:
p/debug_native.c:1421:10: warning: unused variable ‘dbg’ [-Wunused-variable]
  RDebug *dbg = bp->user;
          ^~~
p/native/linux/linux_debug.c: In function ‘print_fpu’:
p/native/linux/linux_debug.c:1058:2: warning: #warning print_fpu not implemented for this platform [-Wcpp]
 #warning print_fpu not implemented for this platform
  ^~~~~~~
p/native/linux/linux_debug.c: In function ‘linux_reg_read’:
p/native/linux/linux_debug.c:1063:7: warning: variable ‘showfpu’ set but not used [-Wunused-but-set-variable]
  bool showfpu = false;
       ^~~~~~~
p/native/linux/linux_debug.c: In function ‘linux_reg_write’:
p/native/linux/linux_debug.c:1268:55: warning: passing argument 4 of ‘r_debug_ptrace’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   int ret = r_debug_ptrace (dbg, PTRACE_SETREGS, pid, buf, NULL);
                                                       ^~~
In file included from p/native/linux/linux_debug.c:6:0:
/home/travis/build/radareorg/radare2/libr/include/r_debug.h:608:20: note: expected ‘void *’ but argument is of type ‘const unsigned char *’
 static inline long r_debug_ptrace(RDebug *dbg, r_ptrace_request_t request, pid_t pid, void *addr, r_ptrace_data_t data) {
                    ^~~~~~~~~~~~~~
At top level:
p/native/linux/linux_debug.c:970:13: warning: ‘print_fpu’ defined but not used [-Wunused-function]
 static void print_fpu(void *f){
             ^~~~~~~~~
+make install