Closed dyc3 closed 2 years ago
This character is used for comments. So it ignores everything until the end of the line. Did you tried with the newshell?
The issue does not occur with cfg.newshell=true
.
i think the issue is in newshell. after # NOTHING should be parsed
Since the switch to newshell solves this problem and the complete switch is imminent, I propose to close this issue.
Please re-read my answer: Its the newshell who is not behaving properly. The oldshell works as expected
@trufae I just retried it with e cfg.newshell=true
that I have by default for a month and ?#;v"
returns exactly the same result as ?
. Moreover, if I set e cfg.newshell=false
and run ?#;v"
it starts visual panels. So it's the old shell that doesn't work properly.
i think the new shell is correct.
uhm im trying and i dont see oldshell or newshell executing anything after ; so maybe i missunderstood the problem here. because i dont get visual panels with or wihout the shell thing set
That's weird. I'm unable to verify if it's been fixed on master already because make
is failing for some reason.
Which error? r2 builds fine here as well as in all the CI using meson and make
the error is: make[3]: *** No rule to make target 'p/spc700.mk'. Stop.
this happens because you didnt executed ./configure after git pull. to avoid such errors i recommend to use the sys/install.sh
That worked, thanks.
I can confirm that this bug still occurs. Version info:
radare2 4.6.0-git 25157 @ linux-x86-64 git.4.4.0-792-g92b8de076
commit: 92b8de07643eaaa911fff93d11581b5f7301ecc6 build: 2020-10-15__14:18:35
Sorry i didnt saw the last quote char. the issue is fixed in a PR now
Work environment
commit: 6c89716d44cc6198d9ac1dcc632d4e1b71e6b714 build: 2020-10-10__22:51:30
Expected behavior
Print help text
Actual behavior
Activates visual mode
Steps to reproduce the behavior
?#;v"
Note that any command can take the place of
?
Additional Logs, screenshots, source-code, configuration dump, ...
This is also the cause of some projects not loading. Projects contain
Cs
commands, followed by a comment and the string as plain text. If any part of the string matches the regex/;.+\"/gi
, then it will try to execute the text after the;
as a command.