radareorg / radare2

UNIX-like reverse engineering framework and command-line toolset
https://www.radare.org/
GNU Lesser General Public License v3.0
20.67k stars 3k forks source link

remove ht.c from radare2 #6049

Closed lowlyw closed 7 years ago

lowlyw commented 8 years ago

just use the version in sdb, it's more correct.

radare commented 8 years ago

we didnt upgraded sdb yet because it breaks 20 tests, the ht is not behaving as it was doing before yet. and ret2libc and me plan to rework on that ht still for some time, i dont think we can stabilize it for 1.0

On 27 Oct 2016, at 09:29, Lowly Worm notifications@github.com wrote:

just use the version in sdb, it's more correct.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/6049, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lrDhqgezVBFz7Jm1uawmgvZGFaytks5q4FLxgaJpZM4KiBt_.

radare commented 8 years ago

in fact we should be able to switch just the ht.c and drop the ht64 and it should work fine, without updating sdb, because the pending feature for this hashtable is to allow keys to be sorted. we can handle this into SdvKv holding another RListIter. so it should be in theory quick to do, but im afraid of the regressions or problems that can come later. Mainly because i dont have much time and i dont see anyone else with the mood

On 27 Oct 2016, at 12:11, pancake@nopcode.org wrote:

we didnt upgraded sdb yet because it breaks 20 tests, the ht is not behaving as it was doing before yet. and ret2libc and me plan to rework on that ht still for some time, i dont think we can stabilize it for 1.0

On 27 Oct 2016, at 09:29, Lowly Worm <notifications@github.com mailto:notifications@github.com> wrote:

just use the version in sdb, it's more correct.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/6049, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lrDhqgezVBFz7Jm1uawmgvZGFaytks5q4FLxgaJpZM4KiBt_.

alvarofe commented 7 years ago

there is another issue