search

radareorg / radare2

UNIX-like reverse engineering framework and command-line toolset
https://www.radare.org/
GNU Lesser General Public License v3.0
20.73k stars 3.01k forks source link

nbbs -> nodes / basicblocks #6095

Closed radare closed 7 years ago

radare commented 8 years ago

Shuold we change the variables and json fields of afij from nbbs to nodes or so

alvarofe commented 7 years ago

I understand nbbs as number of basic blocks but if we change it, as you've already commented with me on private, might break some scripts and guis that depend on this. However, updating such scripts is not a pain, is just a matter of use sed. I would go instead to document r2pipe and the different json that r2 is able to give. Dunno why would be the best way to do it.

radare commented 7 years ago

so let's close it, nbbs lgtm too, but i nwas looking for some feedback that nobody gave in a month. thanks