Closed XVilka closed 7 years ago
if it's segfault it's msys fault, not r2
@radare will ping msys2 devs, please keep it open to track things down. This code seems to work (from IRC):
71a72
> TMPSHFILE:=$(shell mktemp)
73,83c74,86
< @for a in ${OBJS} ${SHARED_OBJ} ${SRC}; do \
< do=0 ; [ ! -e ${LIBSO} ] && do=1 ; \
< test $$a -nt ${LIBSO} && do=1 ; \
< if [ $$do = 1 ]; then \
< [ -n "${SILENT}" ] && \
< echo "LD $(LIBSO)" || \
< echo "${CC_LIB} ${LIBNAME} ${OBJS} ${SHARED_OBJ} ${LINK} ${LDFLAGS}" ; \
< ${CC_LIB} ${LIBNAME} ${CFLAGS} ${OBJS} ${SHARED_OBJ} ${LINK} ${LDFLAGS} || exit 1; \
< [ -f "$(LIBR)/stripsyms.sh" ] && sh $(LIBR)/stripsyms.sh ${LIBSO} ${NAME} ; \
< break ; \
< fi ; done
---
> echo "for a in ${OBJS} ${SHARED_OBJ} ${SRC}; do" >>${TMPSHFILE}
> echo " do=0 ; [ ! -e ${LIBSO} ] && do=1 ;" >>${TMPSHFILE}
> echo " test \\$$a -nt ${LIBSO} && do=1 ;" >>${TMPSHFILE}
> echo " if [ \\$$do = 1 ]; then" >>${TMPSHFILE}
> echo " [ -n \"${SILENT}\" ] &&" >>${TMPSHFILE}
> echo " echo \"LD $(LIBSO)\" ||" >>${TMPSHFILE}
> echo " echo \"${CC_LIB} ${LIBNAME} ${OBJS} ${SHARED_OBJ} ${LINK} ${LDFLAGS}\" ;" >>${TMPSHFILE}
> echo " ${CC_LIB} ${LIBNAME} ${CFLAGS} ${OBJS} ${SHARED_OBJ} ${LINK} ${LDFLAGS} || exit 1;" >>${TMPSHFILE}
> echo " [ -f \"$(LIBR)/stripsyms.sh\" ] && sh $(LIBR)/stripsyms.sh ${LIBSO} ${NAME} ;" >>${TMPSHFILE}
> echo " break ;" >>${TMPSHFILE}
> echo "fi ; done" >>${TMPSHFILE}
> @sh ${TMPSHFILE}
> @rm ${TMPSHFILE}
Wtf a non unified diff in 2017?
On 11 Jan 2017, at 18:38, Anton Kochkov notifications@github.com wrote:
@radare will ping msys2 devs, please keep it open to track things down. This code seems to work (from IRC):
71a72
TMPSHFILE:=$(shell mktemp) 73,83c74,86 < @for a in ${OBJS} ${SHARED_OBJ} ${SRC}; do \ < do=0 ; [ ! -e ${LIBSO} ] && do=1 ; \ < test $$a -nt ${LIBSO} && do=1 ; \ < if [ $$do = 1 ]; then \ < [ -n "${SILENT}" ] && \ < echo "LD $(LIBSO)" || \ < echo "${CC_LIB} ${LIBNAME} ${OBJS} ${SHARED_OBJ} ${LINK} ${LDFLAGS}" ; \ < ${CC_LIB} ${LIBNAME} ${CFLAGS} ${OBJS} ${SHARED_OBJ} ${LINK} ${LDFLAGS} || exit 1; \ < [ -f "$(LIBR)/stripsyms.sh" ] && sh $(LIBR)/stripsyms.sh ${LIBSO} ${NAME} ; \ < break ; \ < fi ; done
echo "for a in ${OBJS} ${SHARED_OBJ} ${SRC}; do" >>${TMPSHFILE} echo " do=0 ; [ ! -e ${LIBSO} ] && do=1 ;" >>${TMPSHFILE} echo " test \\$$a -nt ${LIBSO} && do=1 ;" >>${TMPSHFILE} echo " if [ \\$$do = 1 ]; then" >>${TMPSHFILE} echo " [ -n \"${SILENT}\" ] &&" >>${TMPSHFILE} echo " echo \"LD $(LIBSO)\" ||" >>${TMPSHFILE} echo " echo \"${CC_LIB} ${LIBNAME} ${OBJS} ${SHARED_OBJ} ${LINK} ${LDFLAGS}\" ;" >>${TMPSHFILE} echo " ${CC_LIB} ${LIBNAME} ${CFLAGS} ${OBJS} ${SHARED_OBJ} ${LINK} ${LDFLAGS} || exit 1;" >>${TMPSHFILE} echo " [ -f \"$(LIBR)/stripsyms.sh\" ] && sh $(LIBR)/stripsyms.sh ${LIBSO} ${NAME} ;" >>${TMPSHFILE} echo " break ;" >>${TMPSHFILE} echo "fi ; done" >>${TMPSHFILE} @sh ${TMPSHFILE} @rm ${TMPSHFILE}
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
on my version of msys2 (latest: 01/28/2017) it doesn't crash. it just builds.