search

radareorg / radare2

UNIX-like reverse engineering framework and command-line toolset
https://www.radare.org/
GNU Lesser General Public License v3.0
20.62k stars 3k forks source link

Incorrect FSF address #8123

Closed xambroz closed 7 years ago

xambroz commented 7 years ago

Some of the files contain incorrect (old) address to FSF in the license terms: radare2-1.6.0/libr/asm/arch/sh/gnu/sh-opc.h radare2-1.6.0/libr/hash/md4.c radare2-1.6.0/libr/asm/arch/tricore/gnu/tricore-dis.c radare2-1.6.0/libr/asm/arch/hexagon/gnu/opcode/hexagon.h radare2-1.6.0/libr/asm/arch/hexagon/gnu/hexagon-dis.c radare2-1.6.0/libr/asm/arch/sh/gnu/sh-dis.c radare2-1.6.0/libr/asm/arch/tricore/gnu/cpu-tricore.c radare2-1.6.0/libr/asm/arch/hexagon/gnu/hexagon-opc.c radare2-1.6.0/libr/asm/arch/tricore/gnu/tricore-opc.c radare2-1.6.0/libr/asm/arch/include/opcode/tricore.h

Address contained:

Should be: Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA

Best regards Michal Ambroz

radare commented 7 years ago

is this license chance already in binutils code? i would rather update the whole file from last binutils than changing just the license line. but i think that some of them are already updated, so you may probably report that to all those forks of binutils and binutils itself

On 4 Aug 2017, at 14:24, xambroz notifications@github.com wrote:

Some of the files contain incorrect (old) address to FSF in the license terms: radare2-1.6.0/libr/asm/arch/sh/gnu/sh-opc.h radare2-1.6.0/libr/hash/md4.c radare2-1.6.0/libr/asm/arch/tricore/gnu/tricore-dis.c radare2-1.6.0/libr/asm/arch/hexagon/gnu/opcode/hexagon.h radare2-1.6.0/libr/asm/arch/hexagon/gnu/hexagon-dis.c radare2-1.6.0/libr/asm/arch/sh/gnu/sh-dis.c radare2-1.6.0/libr/asm/arch/tricore/gnu/cpu-tricore.c radare2-1.6.0/libr/asm/arch/hexagon/gnu/hexagon-opc.c radare2-1.6.0/libr/asm/arch/tricore/gnu/tricore-opc.c radare2-1.6.0/libr/asm/arch/include/opcode/tricore.h

Address contained:

in majority cases it is: Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. once there is: Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. Should be: Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA

Best regards Michal Ambroz

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/8123, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lvotC0DGsEu66RX4G77__ANoA-DQks5sUw2WgaJpZM4OtpsL.

radare commented 7 years ago

send a pullreq instead of reporting that way, takes the same time in your side, gives you credit for the change and reduces our review time. thanks

On 4 Aug 2017, at 14:24, xambroz notifications@github.com wrote:

Some of the files contain incorrect (old) address to FSF in the license terms: radare2-1.6.0/libr/asm/arch/sh/gnu/sh-opc.h radare2-1.6.0/libr/hash/md4.c radare2-1.6.0/libr/asm/arch/tricore/gnu/tricore-dis.c radare2-1.6.0/libr/asm/arch/hexagon/gnu/opcode/hexagon.h radare2-1.6.0/libr/asm/arch/hexagon/gnu/hexagon-dis.c radare2-1.6.0/libr/asm/arch/sh/gnu/sh-dis.c radare2-1.6.0/libr/asm/arch/tricore/gnu/cpu-tricore.c radare2-1.6.0/libr/asm/arch/hexagon/gnu/hexagon-opc.c radare2-1.6.0/libr/asm/arch/tricore/gnu/tricore-opc.c radare2-1.6.0/libr/asm/arch/include/opcode/tricore.h

Address contained:

in majority cases it is: Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. once there is: Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. Should be: Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA

Best regards Michal Ambroz

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/8123, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lvotC0DGsEu66RX4G77__ANoA-DQks5sUw2WgaJpZM4OtpsL.