radareorg / radare2

UNIX-like reverse engineering framework and command-line toolset
https://www.radare.org/
GNU Lesser General Public License v3.0
20.37k stars 2.97k forks source link

pd syntax #9466

Closed radare closed 6 years ago

radare commented 6 years ago

Recently i find out a bunch of inconsistencies.

Solutions:

michaelbr92 commented 6 years ago

I think that arch/bits and the parsing of the arguments are 2 different issues.
The first is to remove all uses and settings of arch and bits for the config.
and the second one will be to change the parsing of length in the command line.

correct me if I'm wrong.

radare commented 6 years ago

What dl u mean by remove all uses and settings of arch and bits?

Imho this issue is only for the 2nd thing you mentioned. And it was suposed to be a place a discuss if we all agree on that behaviour change.

On 28 Feb 2018, at 19:37, michaelbr92 notifications@github.com wrote:

I think that arch/bits and the parsing of the arguments are 2 different issues. The first is to remove all uses and settings of arch and bits for the config. and the second one will be to change the parsing of length in the command line.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

michaelbr92 commented 6 years ago

while pd1 is really fast to type I think that it will be confusing in the other pd commands and in large numbers (ex. pd342 in comparison to pd 342) but I agree that removing arch and bits from the command will be necessary

radare commented 6 years ago

If nobody is going to complain about this (except travis) i’ll do this change later tonight

On 2 Mar 2018, at 17:01, michaelbr92 notifications@github.com wrote:

while pd1 is really fast to type I think that it will be confusing in the other pd commands and in large numbers (ex. pd342 in comparison to pd 342) but I agree that removing arch and bits from the command will be necessary

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

michaelbr92 commented 6 years ago

What change? the length parsing?

On Fri, Mar 2, 2018, 8:02 PM radare notifications@github.com wrote:

If nobody is going to complain about this (except travis) i’ll do this change later tonight

On 2 Mar 2018, at 17:01, michaelbr92 notifications@github.com wrote:

while pd1 is really fast to type I think that it will be confusing in the other pd commands and in large numbers (ex. pd342 in comparison to pd 342) but I agree that removing arch and bits from the command will be necessary

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/9466#issuecomment-370001297, or mute the thread https://github.com/notifications/unsubscribe-auth/AI-qJk14KxJfo7CbaFlfAxtd7h_Z6HVUks5taYkkgaJpZM4SPekU .

radare commented 6 years ago

And remove the space split logic to select arch and bits because we have @a: and @b:

On 2 Mar 2018, at 19:39, michaelbr92 notifications@github.com wrote:

What change? the length parsing?

On Fri, Mar 2, 2018, 8:02 PM radare notifications@github.com wrote:

If nobody is going to complain about this (except travis) i’ll do this change later tonight

On 2 Mar 2018, at 17:01, michaelbr92 notifications@github.com wrote:

while pd1 is really fast to type I think that it will be confusing in the other pd commands and in large numbers (ex. pd342 in comparison to pd 342) but I agree that removing arch and bits from the command will be necessary

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/9466#issuecomment-370001297, or mute the thread https://github.com/notifications/unsubscribe-auth/AI-qJk14KxJfo7CbaFlfAxtd7h_Z6HVUks5taYkkgaJpZM4SPekU .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

radare commented 6 years ago

Fixed by @ret2libc