radareorg / sdb

Simple and fast string based key-value database with support for arrays and json
https://www.radare.org/
MIT License
217 stars 62 forks source link

Rhashtable2 #102

Closed crowell closed 8 years ago

crowell commented 8 years ago

replace the hashtable with one that can handle collisions.

not sure how to test this, but it works from my small amount of testing by hand...

radare commented 8 years ago

maybe we should remove the hashtable implementation of r2 and, as long as sdb goes into rutil now, just use the one in sdb, to avoid duppes. what do you think?

On 21 Jun 2016, at 06:12, Jeffrey Crowell notifications@github.com wrote:

replace the hashtable with one that can handle collisions.

not sure how to test this, but it works from my small amount of testing by hand...

You can view, comment on, or merge this pull request online at:

https://github.com/radare/sdb/pull/102 https://github.com/radare/sdb/pull/102 Commit Summary

start doing stuff beep it works! fix warnings introduced in the change File Changes

M src/ht.c https://github.com/radare/sdb/pull/102/files#diff-0 (375) M src/ht.h https://github.com/radare/sdb/pull/102/files#diff-1 (72) M src/sdb.c https://github.com/radare/sdb/pull/102/files#diff-2 (135) M src/sdb.h https://github.com/radare/sdb/pull/102/files#diff-3 (7) M src/types.h https://github.com/radare/sdb/pull/102/files#diff-4 (1) Patch Links:

https://github.com/radare/sdb/pull/102.patch https://github.com/radare/sdb/pull/102.patch https://github.com/radare/sdb/pull/102.diff https://github.com/radare/sdb/pull/102.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/radare/sdb/pull/102, or mute the thread https://github.com/notifications/unsubscribe/AA3-lkSS86W6f16rAFqyKd8QvpRzYETcks5qN2TGgaJpZM4I6WGf.

crowell commented 8 years ago

i think that's a pretty good idea.

radare commented 8 years ago

can you squash all those commits to ease the review? thx!

radare commented 8 years ago

stress1 make[1]: *\ [stress1] Segmentation fault (core dumped)

radare commented 8 years ago

squash rebase and make it optional at compile time

radare commented 8 years ago

I have merged and fixed the comments in c6bb35f71e67aa7a3c2e59063bc4e6d032b14ebf

Thanks!

About speed, looks like there's no difference by running the tests/