search

radareorg / sdb

Simple and fast string based key-value database with support for arrays and json
https://www.radare.org/
MIT License
217 stars 62 forks source link

Kill SdbHt or Ht #152

Open radare opened 6 years ago

radare commented 6 years ago

i would go for ht. this means that r2 cant use this api

screen shot 2018-05-09 at 16 48 32
condret commented 6 years ago

is this the dict api?

radare commented 6 years ago

No

On 9 May 2018, at 23:55, condret notifications@github.com wrote:

is this the dict api?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ret2libc commented 6 years ago

SdbHt defined in sdb/src/sdbht.h seems to be just an extension on top of sdb/src/ht.h.

Anyway, I would keep only ht.h as well. I've used it successfully in xrefs, we just need to reintroduce growing.

radare commented 6 years ago

The sdb prefix is to keep the namespace prefix in place and avoid conflicts with other hashtable implementations. If its a public api, aka used outside sdb it must keep that

On 31 Jul 2018, at 16:33, Riccardo Schirone notifications@github.com wrote:

SdbHt defined in sdb/src/sdbht.h seems to be just an extension on top of sdb/src/ht.h.

Anyway, I would keep only ht.h as well. I've used it successfully in xrefs, we just need to reintroduce growing.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.