search

radareorg / sdb

Simple and fast string based key-value database with support for arrays and json
https://www.radare.org/
MIT License
217 stars 62 forks source link

use "generics" approach to create multiple Ht types #177

Closed ret2libc closed 6 years ago

ret2libc commented 6 years ago

@radare if you want to rename things this seems like the right moment!

ret2libc commented 6 years ago

@radare I fixed the naming! Please tell me what you think :)

ret2libc commented 6 years ago

Yeah I couldn't actually think of other cases where you don't want a void* as value. The other naming could be:

HtUU, HtUP, HtPP. What about these?

radare commented 6 years ago

Yeah sounds better to me. Not sure how many we will have to replicate but looks less confusing to me

On 11 Nov 2018, at 14:06, Riccardo Schirone notifications@github.com wrote:

Yeah I couldn't actually think of other cases where you don't want a void* as value. The other naming could be:

HtUU, HtUP, HtPP. What about these?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ret2libc commented 6 years ago

Ok, it's fine with me too. I think we won't need more then HtUU, HtUP and HtPP. They seem to cover pretty much all use cases to me. Of course, you can always subclass it even further, but with void * as type you cover everything quite easily.

I will rename things soon.

ret2libc commented 6 years ago

Ok, Everything was addressed.