search

radarku / ardupilot-sitl-docker

Docker container for ArduPilot Software-in-the-Loop Simulator
Apache License 2.0
43 stars 28 forks source link

Incorrect Command For Docker Run #15

Closed OliverHeilmann closed 1 year ago

OliverHeilmann commented 1 year ago

Short one from me! Tried to do a pull request but don't have permissions. In the README.md options section the command to run a rover docker container is 

docker run -it --rm -p 5761:5760 --env VEHICLE=APMRover2 ardupilot

Similar deal with another line. This command is not correct as the output with this code is:

sim_vehicle.py: error: option --vehicle: invalid choice: 'APMRover2' (choose from 'ArduCopter', 'AntennaTracker', 'APMrover2', 'ArduSub', 'ArduPlane')

These two lines should read APMrover2 rather than APMRover2. Alternatively, as all the other types have capital letters, perhaps a parameter change in the docker image is better? Up to you, thought I'd point it out though!

radarku commented 1 year ago

Hi @OliverHeilmann - I updated the README to reflect the capitalization; can you confirm that my change addressed your comment completely, please? If not, please re-open this issue. Thanks!