cookie -> sessionStorage changes

radarlabs / radar-sdk-js

Web JavaScript SDK for Radar, the leading geofencing and location tracking platform

https://radar.com

Apache License 2.0

42 stars 11 forks source link

cookie -> sessionStorage changes #67

Closed joekuttickal closed 2 years ago

joekuttickal commented 2 years ago

https://app.shortcut.com/radarlabs/story/10853/port-data-stored-in-cookies-to-sessionstorage-for-radar-js-sdk

shortcut-integration[bot] commented 2 years ago

This pull request has been linked to Shortcut Story #10853: port data stored in cookies to sessionStorage for radar-js-sdk.

lgtm-com[bot] commented 2 years ago

This pull request introduces 5 alerts and fixes 1 when merging 5275802b92313cd35391a298daab6ffad1f4d60e into 3325eea16549ab9a23204f9a5872e9cddf2785dd - view on LGTM.com

new alerts:

5 for Comparison between inconvertible types

fixed alerts:

1 for Comparison between inconvertible types

lgtm-com[bot] commented 2 years ago

This pull request introduces 5 alerts and fixes 1 when merging 1d12c135f98c1e28a5bd8ae79e96bd87713fa429 into 3325eea16549ab9a23204f9a5872e9cddf2785dd - view on LGTM.com

new alerts:

5 for Comparison between inconvertible types

fixed alerts:

1 for Comparison between inconvertible types

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts and fixes 1 when merging 30bf079b9eef7f55455e65ad644b8a2e2a72828b into 3325eea16549ab9a23204f9a5872e9cddf2785dd - view on LGTM.com

new alerts:

2 for Comparison between inconvertible types

fixed alerts:

1 for Comparison between inconvertible types

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts and fixes 1 when merging f9874fb052e6ea3c0bac990abf0e919832a38ef1 into 3325eea16549ab9a23204f9a5872e9cddf2785dd - view on LGTM.com

new alerts:

2 for Comparison between inconvertible types

fixed alerts:

1 for Comparison between inconvertible types

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts and fixes 1 when merging 1bf592d8c07a006f9ae5666960881229369a2ad3 into 3325eea16549ab9a23204f9a5872e9cddf2785dd - view on LGTM.com

new alerts:

2 for Comparison between inconvertible types

fixed alerts:

1 for Comparison between inconvertible types

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts and fixes 1 when merging 16a040c401b8a370d684da6a9b68813379a5c1e6 into 3325eea16549ab9a23204f9a5872e9cddf2785dd - view on LGTM.com

new alerts:

2 for Comparison between inconvertible types

fixed alerts:

1 for Comparison between inconvertible types

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts and fixes 1 when merging 4d8704b273c2115ed75ff63491db97886f42329d into 3325eea16549ab9a23204f9a5872e9cddf2785dd - view on LGTM.com

new alerts:

2 for Comparison between inconvertible types

fixed alerts:

1 for Comparison between inconvertible types

jkao commented 2 years ago

how did you QA this?

joekuttickal commented 2 years ago

i just ran the local tests:

and also ran the sdk locally and used dev tools to verify that session storage is being populated:

jkao commented 2 years ago

this ERROR_UNAUTHORIZED message seems to imply it isn't QA'ed.

looks like the header -H 'Authorization: true' is incorrect. going to investigate.

jkao commented 2 years ago

I have a fix for the above; there was logic error in the sessionStorage helper.

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging 7e1310dfa73edb05b6fd16197cf40b2ff8c99fec into 3325eea16549ab9a23204f9a5872e9cddf2785dd - view on LGTM.com

fixed alerts:

1 for Comparison between inconvertible types

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging 85e8c3ed6e40b67c64a675bcf17997d9bc14b43e into 3325eea16549ab9a23204f9a5872e9cddf2785dd - view on LGTM.com

fixed alerts:

1 for Comparison between inconvertible types

jkao commented 2 years ago

I'm going to update this to a beta version "just in case"

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging 6d374ce3545639fda46ba286213566c8bb33b1f3 into 3325eea16549ab9a23204f9a5872e9cddf2785dd - view on LGTM.com

fixed alerts:

1 for Comparison between inconvertible types

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging 40dd7fbd8278d27dbbb40a34f6087fa0f983f87f into 3325eea16549ab9a23204f9a5872e9cddf2785dd - view on LGTM.com

fixed alerts:

1 for Comparison between inconvertible types