Track verified changes - Githubissues

radarlabs / react-native-radar

React Native module for Radar, the leading geofencing and location tracking platform

https://radar.com

Apache License 2.0

170 stars 32 forks source link

Track verified changes #286

Closed york-wei closed 9 months ago

york-wei commented 10 months ago

Upgrades Radar Android SDK to 3.9.4and iOS SDK to 3.9.6
Adds a beacons param to Radar.trackVerified() and Radar.trackVerifiedToken() to support beacon ranging.
Adds Radar.startTrackingVerified(token, interval, beacons), which calls Radar.trackVerified() or Radar.trackVerifiedToken() every interval seconds or on network connection changes and delivers updates to listeners.
Adds a token listener for token updates.

york-wei commented 9 months ago

looking good so far.

have you dogfooded this in Waypoint at @york-wei ? Both with startTrackingVerified, running this with beacon: true, and also listening to the "token" event?

verified on waypoint :+1:

york-wei commented 9 months ago

Will rebase on Kenny's typescript changes once it's merged

york-wei commented 9 months ago

@KennyHuRadar @lmeier iOS: https://expo.dev/accounts/radarlabs/projects/waypoint/builds/3ecc2964-8d75-40db-a71e-29a67fa5b784 Android: https://expo.dev/accounts/radarlabs/projects/waypoint/builds/9d00cb5a-9caa-47a9-82e5-322138dddbf4

KennyHuRadar commented 9 months ago

@york-wei tried out the builds on both platforms, trackVerified and trackVerifiedToken looks good, can you share some QA steps for startTrackVerified?

york-wei commented 9 months ago

@york-wei tried out the builds on both platforms, trackVerified and trackVerifiedToken looks good, can you share some QA steps for startTrackVerified?

@KennyHuRadar set Radar.on('token', (result: string) => { console.log('token: ', result); }); and then call Radar.startTrackingVerified({ token: true });

KennyHuRadar commented 9 months ago

@york-wei tried out the builds on both platforms, trackVerified and trackVerifiedToken looks good, can you share some QA steps for startTrackVerified?

@KennyHuRadar set Radar.on('token', (result: string) => { console.log('token: ', result); }); and then call Radar.startTrackingVerified({ token: true });

Just tried this and noticed a type error, Radar.on() takes in string of the Event type, you need to add the string token to that enum within the types file.

Also noticed that Event isn't the best name, if you have any ideas feel free to change the name of the type while you are at it? I'm thinking CallbackChannel?