search

radarlabs / react-native-radar

React Native module for Radar, the leading geofencing and location tracking platform
https://radar.com
Apache License 2.0
170 stars 32 forks source link

Fix for JS projects #307

Closed KennyHuRadar closed 8 months ago

KennyHuRadar commented 8 months ago

The previous upgrade to TS introduced a bug that affected projects on older versions of expo using JS. It appears that just loading the import of radar-js-sdk into the js layer was causing issues. This PR introduces a fix to prevent that from occuring.

KennyHuRadar commented 8 months ago

Did the customer running into the issue verify this fix resolved the issue for them?

I cut a beta and send it to them, no replies yet. The QA that was done was that I somewhat recreated a similar expo project and reproduced the error they send via screenshot. When the new beta with this fix is installed on the same project, the following error does not occur.

image
KennyHuRadar commented 8 months ago

I ran a simple example RN web app with the new changes, seems to work fine.

image