radarlabs / react-native-radar

React Native module for Radar, the leading geofencing and location tracking platform
https://radar.com
Apache License 2.0
171 stars 32 forks source link

also return foreground granted when coarse location is granted #326

Closed ShiCheng-Lu closed 2 months ago

KennyHuRadar commented 2 months ago

we should not ship this, instead we should be writing the RN wrapper for our new location permission handling component.

ShiCheng-Lu commented 2 months ago

this is a patch for a customer that is using the old functions, the new location permission handling is blocked by https://github.com/radarlabs/radar-sdk-android/pull/363. Which would require additional setup, and unless we release it as a major version, we should keep the old function in the RN SDK, so it needs to be patched.

KennyHuRadar commented 2 months ago

Ah I see, I misunderstood the rationale.