Lint, Tests, CircleCI - Githubissues

radarlabs / react-native-radar

React Native module for Radar, the leading geofencing and location tracking platform

https://radar.com

Apache License 2.0

170 stars 32 forks source link

Lint, Tests, CircleCI #59

Closed russellcullen closed 5 years ago

russellcullen commented 5 years ago

( Continued from #58 )

Long overdue checks for this codebase:

Lint checks for JS code
Tests for JS
Tests for Android
Test for iOS

~Will put these checks on CircleCI and they'll be a requirement for future changes.~ 🎉 Done!

Also:

Fixes #54
Fixes #61

nickpatrick commented 5 years ago

😍

nickpatrick commented 5 years ago

Love it! Looks good to me but suggest @tjulien and @kochis review as well.

irfaan commented 5 years ago

Hi! Is the team id supposed to be hard-coded for tests? I'm getting -1: No signing certificate "iOS Development" found: No "iOS Development" signing certificate matching team ID "96GHH65B9D" with a private key was found. (in target 'RNRadarTests')

russellcullen commented 5 years ago

@irfaan - That is a small bug, nice find! A fix is as simple as selecting None or your own development team from the team dropdown in the General tab of RNRadarTests target. All tests should run fine without signing.

It's worth mentioning that unless you're contributing to this repository, there is really no need to run our tests locally - we make sure our shipped SDK is tested for you.