search

radarlabs / react-native-radar

React Native module for Radar, the leading geofencing and location tracking platform
https://radar.com
Apache License 2.0
170 stars 32 forks source link

react native 0.58.4 #74

Closed rogueturnip closed 5 years ago

rogueturnip commented 5 years ago

I'm trying to compile my app with 0.58.4 and other than upgrading the react native version (following usual upgrade steps) I've started seeing a compile problem using react-native run-ios

I've attempted removing node_modules, clearing the pods to no success.

What I'm seeing for errors seems to land in the RadarSDK around Folly and boost-react-native.

In file included from /Users/tony/alana-mobile/node_modules/react-native-radar/ios/RNRadar.m:4: In file included from /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/include/React/RCTConvert.h:17: /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/include/yoga/Yoga.h:11:10: warning: non-portable path to file ''; specified path differs in case from file name on disk [-Wnonportable-include-path]

include 

     ^~~~~~~~
     <Math.h>

In file included from /Users/tony/alana-mobile/node_modules/react-native-radar/ios/RNRadar.m:4: In file included from /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/include/React/RCTConvert.h:17: In file included from /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/include/yoga/Yoga.h:11: In file included from ../../../ios/Pods/Folly/folly/math.h:26: In file included from ../../../ios/Pods/boost-for-react-native/boost/tr1/tr1/limits:16: In file included from ../../../ios/Pods/boost-for-react-native/boost/tr1/detail/config_all.hpp:43: ../../../ios/Pods/boost-for-react-native/boost/compatibility/cpp_c_headers/cstddef:10:1: error: unknown type name 'namespace' namespace std { ^ ../../../ios/Pods/boost-for-react-native/boost/compatibility/cpp_c_headers/cstddef:10:14: error: expected ';' after top level declarator

russellcullen commented 5 years ago

Thanks for the report, what version of react-native-radar are you using, and what was the previous version combination (react native version + react-native-radar version) that compiled successfully?

rogueturnip commented 5 years ago

I'm running 2.1.8 with SDK 2.1.3.

I took a look in your project.pbxproj file and noticed this: HEADER_SEARCH_PATHS = ( "$(inherited)", /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include, "$(SRCROOT)/../../../React/", "$(SRCROOT)/../../react-native/React/", "${SRCROOT}/../../../ios/Pods/RadarSDK/", "${SRCROOT}/../../../ios/RadarSDK/", "$(SRCROOT)/Carthage/Build/iOS/", "${SRCROOT}/../../../ios/", ); From what I understand is that "${SRCROOT}/../../../ios/**" can cause issues so I removed that and the compile goes farther to this error now:

ld: warning: directory not found for option '-L/Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/React' duplicate symbol _OBJCCLASS$_RNRadarUtils in: /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/react-native-radar/libreact-native-radar.a(RNRadarUtils.o) /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/libRNRadar.a(RNRadarUtils.o) duplicate symbol _OBJCMETACLASS$_RNRadarUtils in: /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/react-native-radar/libreact-native-radar.a(RNRadarUtils.o) /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/libRNRadar.a(RNRadarUtils.o) duplicate symbol _OBJCIVAR$_RNRadar.hasListeners in: /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/react-native-radar/libreact-native-radar.a(RNRadar.o) /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/libRNRadar.a(RNRadar.o) duplicate symbol _OBJCIVAR$_RNRadar.locationManager in: /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/react-native-radar/libreact-native-radar.a(RNRadar.o) /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/libRNRadar.a(RNRadar.o) duplicate symbol _OBJCCLASS$_RNRadar in: /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/react-native-radar/libreact-native-radar.a(RNRadar.o) /Users/tony/alana-mobile/ios/build/Build/Products/Debug-iphonesimulator/libRNRadar.a(RNRadar.o)

rogueturnip commented 5 years ago

oh sorry, also the version that did work for me were React native 0.57.9 and Radar react native 2.1.7 SDK 2.1.0.

russellcullen commented 5 years ago

That's interesting, we didn't change anything from version 2.1.7 regarding search paths, I'm guessing it has to do with some change in React Native.

Would you mind sharing some details about your upgrade process? Any other code changes since the last time it compiled?

rogueturnip commented 5 years ago

There are no code changes to the react-native code base other than the upgrade in Radar and React Native.

My upgrade process was react-native-git-upgrade Add the Javascript Framework to XCode Clear node_modules Clear .rncache Clear and reinstall Pods

Does this help?

Sent from Mail for Windows 10

From: Russell Cullen Sent: February 13, 2019 3:54 PM To: radarlabs/react-native-radar Cc: rogueturnip; Author Subject: Re: [radarlabs/react-native-radar] react native 0.58.4 (#74)

That's interesting, we didn't change anything from version 2.1.7 regarding search paths, I'm guessing it has to do with some change in React Native. Would you mind sharing some details about your upgrade process? Any other code changes since the last time it compiled? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

russellcullen commented 5 years ago

Did you run react-native link react-native-radar command after reinstalling the node module and before running pod install? The link command links the iOS framework for you and also sets up the local pod for the library.

rogueturnip commented 5 years ago

I just tried that and got the same error (I put the original SRC lines back in the project file).

Sent from Mail for Windows 10

From: Russell Cullen Sent: February 13, 2019 4:01 PM To: radarlabs/react-native-radar Cc: rogueturnip; Author Subject: Re: [radarlabs/react-native-radar] react native 0.58.4 (#74)

Did you run react-native link react-native-radar command after reinstalling the node module and before running pod install? The link command links the iOS framework for you and also sets up the local pod for the library. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

rogueturnip commented 5 years ago

I tried react-native run-android and it works fine so it seems to be something with iOS only.

rogueturnip commented 5 years ago

I solved it. I had to do a react-native unlink react-radar-native and then relink it. Very strange but the build is succeeding now.