search

radarphp / Radar.Adr

The Action-Domain-Responder core for Radar.
MIT License
55 stars 7 forks source link

Add param for fail responder in RoutingHandler #16

Closed jakejohns closed 9 years ago

jakejohns commented 9 years ago

Add ability to pass $failResponder to RoutingHandler and specify a custom class in place of RoutingFailedResponder

Maybe I'm thinking about this wrong, but I felt like I wanted the ability to override the default routing failed responses, and thought this would be sufficient as oppose to having to always extend the RoutingHandler itself.

Thoughts?

pmjones commented 9 years ago

You're probably right. Let me stare at it for a bit before I merge it. Thanks!

pmjones commented 9 years ago

@harikt Setting a default in the way you suggest is probably the better approach. Send a PR if you like, otherwise I'll do it myself later.