search

radarphp / Radar.Adr

The Action-Domain-Responder core for Radar.
MIT License
55 stars 7 forks source link

Remove Resolver in favor of Di\ResolutionHelper #32

Closed jakejohns closed 5 years ago

jakejohns commented 7 years ago

This removes the Resolver and uses in its place the Aura\Di\ResolutionHelper which was added in Auraphp/Aura.Di#143. Since Radar already has a dependency on aura/di right now, it seems reasonable not to duplicate the functionality.

Note: that being said, I do believe this will also have sneaky side effect of accomplishing what I raised in #29. Namely the ability to configure "service level" actions. While the Radar Resolver only attempted to create a new instance. The ResolutionHelper from aura/di actually checks first for a service with that name first.

cxj commented 5 years ago

@jakejohns Do you still think this is a good change to make? How does it change the Radar.Adr API, if at all? Thanks.

cxj commented 5 years ago

Merge checks failed for 2 reasons:

  1. HHVM support (might as well scrap this)
  2. PHPUnit tests for Aura.Di need updating to a version compatible with PHP 7.