Closed jakejohns closed 5 years ago
@harikt @pmjones anybody? ...
Hi,
All looks good. But I am not a maintainer , so I will not be able to merge.
Thank you.
On 06-Nov-2017 04:45, "jake" notifications@github.com wrote:
@harikt https://github.com/harikt @pmjones https://github.com/pmjones anybody? ...
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/radarphp/Radar.Adr/pull/33#issuecomment-342014130, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHWhlUKQ68HEkAiPoa4IewSX-3tYkpnks5szkGJgaJpZM4O-NkT .
My mistake, @harikt. I thought you were a maintainer here for some reason. Thanks.
I want to update to PHP 7.1 as a minimum, I think. Should that become a Radar 2.0 branch? One could argue it's a major change. Also, do we want to continue supporting HHVM? I thought I read somewhere in one of Paul's projects where he had decided to drop it. (I'll go search for that.)
HHVM dropped support for PHP with the 4.0 release in February, 2019. I've updated the Travis configuration to drop HHVM completely, so I think that obviates the need for this PR.
bump @pmjones