WIN32: the nfds parameter of select() is unused.

radarsat1 / liblo

liblo is an implementation of the Open Sound Control protocol for POSIX systems

GNU Lesser General Public License v2.1

192 stars 60 forks source link

WIN32: the nfds parameter of select() is unused. #147

Closed carlo-bramini closed 11 months ago

carlo-bramini commented 1 year ago

Winsock provides an opaque SOCKET type for handling sockets and the nfds parameter of select() is ignored but kept for compatibity with BSD standard. Expecting to handle sockets by not assuming to be an int type, this could cause a complain from MSVC when compiling for 64bit for Windows because incompatible types, so it would be better to just ignore this and just leave nfds to zero for the future. See also here: https://learn.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-select

immagine

JohannesLorenz commented 11 months ago

Thanks for the PR, though there are 2 issues:

CI fails (even for Linux) - maybe we need convert !defined into not defined or use #ifndef?
Is it wanted that the 3rd select call in server.c is not changed by this PR?

carlo-bramini commented 11 months ago

I did the changes that you suggested to me, thank you. Now the CI seems to be fine, except the MAC test that it still hangs, but it doesn't seem to be related to this PR.

JohannesLorenz commented 11 months ago

Yes, we still need to work on the macOS CI :grin: Thanks for fixing, I will merge that.