search

radarsh / gradle-test-logger-plugin

A Gradle plugin for printing beautiful logs on the console while running tests
Apache License 2.0
848 stars 38 forks source link

Adopt Gradle 8 #322

Closed Goooler closed 1 year ago

Goooler commented 1 year ago

Closes #321.

Goooler commented 1 year ago

We can rebase these commits and replace @dependabot with @renovate-bot.

radarsh commented 1 year ago

@Goooler thanks for this pull request. Can you justify why are you switching to renovate bot? I much prefer to use dependabot as it is built into GitHub now.

Goooler commented 1 year ago

Can you justify why are you switching to renovate bot? I much prefer to use dependabot as it is built into GitHub now.

@renovate-bot can send the Gradle updates, and supports more kinds of dep updates.

radarsh commented 1 year ago

Thanks. Lastly, is this PR going to be compatible with Gradle 7?

Goooler commented 1 year ago

is this PR going to be compatible with Gradle 7?

It should work, maybe we should add more Gradle versions into test matrix.

Goooler commented 1 year ago

Did a quick test at https://github.com/Goooler/gradle-test-logger-plugin/pull/27, seems need to fix some tests.

Edited: Not sure why these tests failed, but should not be relevant to the removal of Provider.forUseAtConfigurationTime.

radarsh commented 1 year ago

No problem, looks like some classes introduced in 7.6 are being used in your branch indirectly. I'll do some more checks later and merge this. Thanks once again.

radarsh commented 1 year ago

Thanks once again for a great PR