Closed MarlonPassos-git closed 1 day ago
Hey! There's a new requirement for PRs that introduce new features. Without this requirement met, we won't be able to merge this. Note that this PR can still be included in a beta
prerelease before this requirement is fulfilled.
⚠️ Note: You need to run git rebase main
before this file will appear locally.
Postponing this until v12.4.0, since it conflicts with PR #262 and we don't have an easy way to solve that currently.
Basically, the prerelease
tag triggers a GitHub CI workflow that attempts to cherry-pick the PR into the beta
branch. If that fails, there's no way to manually fix the merge conflict. In the future, I could add a fail-safe to the CI workflow that would open a “clone” PR targeting the beta
branch specifically. Then I could checkout that PR, manually fix the conflict, push the fix, and merge that PR into the beta
branch, triggering a prerelease.
Postponing this until v12.4.0, since it conflicts with PR #262 and we don't have an easy way to solve that currently.
Basically, the
prerelease
tag triggers a GitHub CI workflow that attempts to cherry-pick the PR into thebeta
branch. If that fails, there's no way to manually fix the merge conflict. In the future, I could add a fail-safe to the CI workflow that would open a “clone” PR targeting thebeta
branch specifically. Then I could checkout that PR, manually fix the conflict, push the fix, and merge that PR into thebeta
branch, triggering a prerelease.
fixed 🫡
Summary
now:
Related issue, if any:
https://github.com/orgs/radashi-org/discussions/235 https://github.com/sodiray/radash/issues/426
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact
src/async/parallel.ts
[^1337]: Function size includes the
import
dependencies of the function.