search

radbrt / target-oracle

Singer.io compatible target for Oracle databases
0 stars 14 forks source link

Should sqlalchemy_url be required? #1

Open pnadolny13 opened 1 year ago

pnadolny13 commented 1 year ago

I noticed that the sqlalchemy_url config option doesnt have the required flag, is it supposed to be a required config?

    config_jsonschema = th.PropertiesList(
        th.Property(
            "sqlalchemy_url",
            th.StringType,
            secret=True,  # Flag config as protected.
            required=True,
            description="SQLAlchemy connection string",
        ),

cc @radbrt

radbrt commented 1 year ago

Thanks for reminding me @pnadolny13. I'm personally not a big fan of simply specifying the sqlalchemy url, but I see how it can be practical for many. I have added the other parameters that I am using now, so sqlalchemy_url truly isn't required.

I guess my next step is to specify the options: Either specify the sqlalchemy_url, or specify username+password+++.