radekg / terraform-provisioner-ansible

Ansible with Terraform 0.14.x
Apache License 2.0
572 stars 100 forks source link

fix and in-dockerfile-build #107

Closed egeneralov closed 5 years ago

egeneralov commented 5 years ago

Summary

Fix the "/tmp/tf-ansible-installer: [[: not found"

Created vm with debian 9, and got an error.

digitalocean_droplet.gitlab: Provisioning with 'ansible'...
digitalocean_droplet.gitlab (ansible): Connecting to remote host via SSH...
digitalocean_droplet.gitlab (ansible):   Host: 157.230.29.178
digitalocean_droplet.gitlab (ansible):   User: root
digitalocean_droplet.gitlab (ansible):   Password: false
digitalocean_droplet.gitlab (ansible):   Private key: true
digitalocean_droplet.gitlab (ansible):   SSH Agent: false
digitalocean_droplet.gitlab (ansible):   Checking Host Key: false
digitalocean_droplet.gitlab: Still creating... (50s elapsed)
digitalocean_droplet.gitlab (ansible): Connected!
digitalocean_droplet.gitlab (ansible): Uploading the parent directory '.' of playbook 'gitlab.yml' to '/tmp/tf-ansible-bootstrap/5058f1af8388633f609cadb75a75dc9d'...
digitalocean_droplet.gitlab: Still creating... (1m0s elapsed)
digitalocean_droplet.gitlab: Still creating... (1m10s elapsed)
digitalocean_droplet.gitlab (ansible): Generating temporary ansible inventory...
digitalocean_droplet.gitlab (ansible): Writing temporary ansible inventory to '/tmp/tf-ansible-bootstrap/5058f1af8388633f609cadb75a75dc9d/.inventory-91c92f8d-07df-40f4-9ff9-b026cd6d6e72'...
digitalocean_droplet.gitlab (ansible): Ansible inventory written.
digitalocean_droplet.gitlab (ansible): Installing Ansible 'ansible' using default installer...
digitalocean_droplet.gitlab (ansible): Uploading Ansible installer program to '/tmp/tf-ansible-installer'...
digitalocean_droplet.gitlab (ansible): /tmp/tf-ansible-installer: 6: /tmp/tf-ansible-installer: [[: not found

This simple fix will fix it.

Dockerfile

Now it have multi-stage build.

radekg commented 5 years ago

Hi @egeneralov, thank you for the PR. Could please give a little bit more reasoning for the changes in the Dockerfile?

radekg commented 5 years ago

Closing due to no activity.