radekg / terraform-provisioner-ansible

Ansible with Terraform 0.14.x
Apache License 2.0
572 stars 100 forks source link

Correct loading of private keys in local mode #87

Closed adamwg closed 6 years ago

adamwg commented 6 years ago

Looks like v2 got half of the fix from #53, but was missing the other half, so local mode with a private key specified doesn't work correctly in v2. This fixes it.

radekg commented 6 years ago

Apologies, that was a big rewrite. I‘ll release 2.0.1 tomorrow.

radekg commented 6 years ago

And it is there: https://github.com/radekg/terraform-provisioner-ansible/releases/tag/v2.0.1, thank you again, @adamwg.

adamwg commented 6 years ago

Thanks for the quick response, @radekg! I was able to use the v1 release for my needs for now anyway, but with the v2.0.1 release done I can migrate to v2.

radekg commented 6 years ago

Turns out there were only 15 minutes between "yesterday" and "today". Please report any issues, I know the tests suck a little bit at the moment, more will be added, including integration tests.

Thing like a part of the original fix by yourself should not end up in a regression like this.