search

radekkozak / discordian-plugin

Discordian plugin for tweaking Discordian theme
14 stars 0 forks source link

Overrides status bar visibility #4

Closed Amparose closed 3 years ago

Amparose commented 3 years ago

I use a keyboard shortcut mapped to the command in Hider to show/hide the status bar. When the Discordian Theme plugin is activated, even with Hide status bar disabled, the status bar is never shown.

radekkozak commented 3 years ago

Hi @Amparose , was trying to replicate the issue you're having but to no avail. With newest version of both theme & plugin everything seems to work ok. Can you confirm you've updated version of both?

Also please take note (you probably know this already) that Discordian setting takes precedence. But if you disable it in plugin setting you should be able to freely toggle Status bar with Hider. I'm doing this as we speak and it works.

Still if problem stays, could you send me your vault to debug (minus notes of course) - it would be easier for me to check what is going on there underneath. Thanks

Amparose commented 3 years ago

Hey @radekkozak, I just started a fresh vault and have been able to reproduce my issue with minimal additions so perhaps it is the particular settings I chose.

Here is the test vault: Test-Discordian.zip

radekkozak commented 3 years ago

Thanks again for the zip @Amparose

i tried it, but somehow all the plugins were disabled - both Discordian and Hider. Can i assume you have something like this ?

  1. Discordian Theme -> Hide Status Bar OFF
  2. Then in Hider -> Hide Status Bar either ON or OFF (by the hotkey you mentioned)

I'm trying exactly that and it is working A-OK so i'm wondering what else you ma have set up differently so it would case a problem. I see no snippets in the zip nor

My last hunch would be - and question for you: do you maybe use Writer Mode when you try to enable Status Bar ? Writer Mode takes precedences - it tries to clear the clutter to just write. See https://forum.obsidian.md/t/discordian-theme/10880/31

Another thing (but this should not make a difference i think) - are you on macOS or Windows/Linux ?

radekkozak commented 3 years ago

By the way - judging by the content of Discordian.css in provided zip you're not on the newest version - frankly i cannot say which version of Discordian exactly you use, but i do recommend either way for you to update. Maybe this would take care of the issue (depending how old version of the theme you carry there) /cc @Amparose

Amparose commented 3 years ago

My last hunch would be - and question for you: do you maybe use Writer Mode when you try to enable Status Bar ? Writer Mode takes precedences - it tries to clear the clutter to just write. See https://forum.obsidian.md/t/discordian-theme/10880/31

Bingo! That fixed it in both my test and main vaults. Maybe this should be mentioned in the settings description.

judging by the content of Discordian.css in provided zip you're not on the newest version - frankly i cannot say which version of Discordian exactly you use

That's odd. I deliberately set up the test vault I sent you from scratch, installing the theme from settings. It's a bit weird that it wouldn't be whatever today's version of the CSS is; I did this specifically because there's no version numbering anywhere... it may help to have a semantic version number at the top of your CSS so that things are easier to track.

Thanks for your help in resolving this! Great theme.

radekkozak commented 3 years ago

Uff, glad we worked this out - i was really starting to scratch my head what is going on there. Oh, and thanks for the good word, happy you like the theme !

Maybe this should be mentioned in the settings description.

You're right, i will explicitly mention this in the plugin settings with next update

it may help to have a semantic version number at the top of your CSS so that things are easier to track.

I wish Obsidian simply pick up theme versioning from repository (or better yet made updating theme more or less similar to Community plugins) - but until that is introduced i think this is a good idea as well - it would make things easier to track. Will do just that.

Thanks again for all the suggestions, cheers /cc @Amparose