radeklat / delfino

A toolbox of command line helper script, wrapping tools used during Python development.
MIT License
12 stars 3 forks source link

Make `verify-all` respect disabled and overriden commands #22

Closed jacksmith15 closed 2 years ago

jacksmith15 commented 2 years ago

Related issue: #20

This PR changes the verify-all command, so that overriden and disabled commands are respected by it.

It also adds a configuration option so that users can fine-tune what's included, the ordering, and add entirely new commands.

I think parts of this logic should be applied to other command groups (e.g. lint), but I'm not sure it should be part of this PR, as there are differences in how we might want to solve it. For example the lint group could just match every command called lint-*? Or it could have a separate config option, but that might get messy.

codecov[bot] commented 2 years ago

Codecov Report

Merging #22 (1506b3c) into main (9aa0f69) will decrease coverage by 0.12%. The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   48.77%   48.65%   -0.13%     
==========================================
  Files          20       20              
  Lines         695      707      +12     
  Branches       94       97       +3     
==========================================
+ Hits          339      344       +5     
- Misses        353      360       +7     
  Partials        3        3              
Flag Coverage Δ
integration_tests 5.79% <11.11%> (+0.04%) :arrow_up:
total 48.51% <55.55%> (-0.12%) :arrow_down:
unit_tests 48.51% <55.55%> (-0.12%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/delfino/click_utils/command.py 75.00% <40.00%> (-8.34%) :arrow_down:
src/delfino/commands/verify_all.py 68.42% <54.54%> (-14.92%) :arrow_down:
src/delfino/models/pyproject_toml.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.