search

radeklat / delfino

A toolbox of command line helper script, wrapping tools used during Python development.
MIT License
12 stars 3 forks source link

Add "filepaths" argument to the lint and format #33

Closed shimpeko closed 2 years ago

shimpeko commented 2 years ago

Add "filepaths" argument, which was introduced by https://github.com/radeklat/delfino/pull/28 for the typecheck command, to the lint and format commands.

codecov[bot] commented 2 years ago

Codecov Report

Base: 47.86% // Head: 48.50% // Increases project coverage by +0.63% :tada:

Coverage data is based on head (9b32e56) compared to base (e34c621). Patch coverage: 41.50% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== + Coverage 47.86% 48.50% +0.63% ========================================== Files 21 21 Lines 750 767 +17 Branches 109 109 ========================================== + Hits 359 372 +13 - Misses 388 392 +4 Partials 3 3 ``` | Flag | Coverage Δ | | |---|---|---| | integration_tests | `5.99% <0.00%> (-0.14%)` | :arrow_down: | | total | `48.37% <41.50%> (+0.63%)` | :arrow_up: | | unit_tests | `48.37% <41.50%> (+0.63%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+L%C3%A1t#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/radeklat/delfino/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+L%C3%A1t) | Coverage Δ | | |---|---|---| | [src/delfino/utils.py](https://codecov.io/gh/radeklat/delfino/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+L%C3%A1t#diff-c3JjL2RlbGZpbm8vdXRpbHMucHk=) | `33.33% <20.00%> (-23.81%)` | :arrow_down: | | [src/delfino/commands/typecheck.py](https://codecov.io/gh/radeklat/delfino/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+L%C3%A1t#diff-c3JjL2RlbGZpbm8vY29tbWFuZHMvdHlwZWNoZWNrLnB5) | `48.48% <33.33%> (+11.52%)` | :arrow_up: | | [src/delfino/commands/lint.py](https://codecov.io/gh/radeklat/delfino/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+L%C3%A1t#diff-c3JjL2RlbGZpbm8vY29tbWFuZHMvbGludC5weQ==) | `46.57% <50.00%> (+4.38%)` | :arrow_up: | | [src/delfino/commands/format.py](https://codecov.io/gh/radeklat/delfino/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+L%C3%A1t#diff-c3JjL2RlbGZpbm8vY29tbWFuZHMvZm9ybWF0LnB5) | `40.00% <83.33%> (+8.42%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+L%C3%A1t). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+L%C3%A1t)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

shimpeko commented 2 years ago

Closing as this is not compatible with https://github.com/radeklat/delfino/issues/34 as described in https://github.com/radeklat/delfino/issues/34#issuecomment-1253453796.