search

radekxrandom / device_bridge

[Unmaintained] Scan the qr code with your phone's camera and be able to easily share files between those two devices. You can add as many devices as you want, you only need to scan a qr code (re-generated every 2 minutes)
https://device-bridge.vercel.app/
Apache License 2.0
1 stars 0 forks source link

DisconnectedViewContainer possible refactoring #7

Open v-bondarenko364 opened 3 years ago

v-bondarenko364 commented 3 years ago

https://github.com/radekxrandom/device_bridge/blob/95b810411554fce0a641294c193e3faeba369f21/front/src/disconnected/DisconnectedViewContainer.js#L3

Where possible you should simplify components to:

const DisconnectedViewContainer = props => (
        <div className='qrBox'>
            <p className='qrBoxTopText'>No device connected</p>
            {props.children}
            <p className='qrBoxBottomText'><span className='bolder'>Scan</span> the <span className='bolder'>QR code</span> with your device in order to connect</p>
        </div>
);
radekxrandom commented 3 years ago

i agree