nus-se-script
commented
2 months ago Team's Response
We use id/ to uniquely identify each student. It is already declared on UG. In this instance, the inputting id is 00001, which is duplicated with Alex yeoh. Therefore we consider the person already exists.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Add command doesn't work
The given command is:
add n/John Doe p/93333333, 92222222 e/johndoe@mail.com a/123 Oxford Street id/00001 class/3A t/Band(same as the one given in the UG).The error message states that the person already exists in the contact list. This is because the given student ID is already in the default data file.
Steps to reproduce:
- Launch the jar file with the default json data file.
- Enter the command and run it.
Reason for severity: The bug causes significant inconvenience for new users learning to use the app.
Suggestion: The student ID in the example of the UG should be changed to something that doesn't already exist in the default data file.
[original: nus-cs2103-AY2324S2/pe-interim#1589] [original labels: severity.Medium type.DocumentationBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Behavior regarding duplicate student IDs is stated clearly in the user guide for new users. New users should be able to understand what needs to be done in order to execute the provided sample command and hence this issue would only very rarely affect normal operations of the application.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** The team has given this very important information like the unique student Id in "additional notes", instead I feel this should be placed in bold at the start of the "add" command in the UG. Since this hampers the users from being able to use the add command altogether. The additional notes should be if the user needs to fine tune the entry of a student, and shouldn't be for a basic functionality like addition. The team says: "New users should be able to understand what needs to be done in order to execute the provided sample command and hence this issue would only very rarely affect normal operations of the application." However the team should acknowledge that 2 testers in this PE got confused and reported the exact same issue. This should be alarming and the dev team shouldn't assume that this is quite intuitive for the users and should try to make it more user friendly by highlighting this important information.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I disagree with the dev team regarding the severity of this issue, as the "add" command is the most basic functionality of this app, and complicating that would severely discourage the users from using the app altogether as this is the first command any user would try. Instead of going through extensive documentation to find out where the user is making a mistake, the dev team should highlight the unique student Id point high up in the UG, since otherwise this would greatly hamper the user experience of the app if they are finding it difficult to even add a student.
On running the exact "add" command example given in the UG, the app raised the error of "This person already exists in the contact list." whereas no where in the person's list is the person mentioned. As you can see in the images below "John Doe" is not present.
This should be fixed as it is a basic requirement for the add command of the app