radeon2525 / pe

0 stars 0 forks source link

Incorrect output after executing undo command #4

Open radeon2525 opened 2 months ago

radeon2525 commented 2 months ago

In the first screenshot, you can see that "Bernice Yu" is in index 1.

image.png

However after deleting her by using the student id "00002" and then executing undo, Bernice is now at index 6, which is not the same as the previous index postion.

image.png

This can really distort the database for any organization who are trying to manage their students.

soc-pe-bot commented 2 months ago

Team's Response

I don’t think the order will distort the database as we don’t use index in the list for any command. Instead, we use student id to uniquely identify a student. The main purpose of this undo command is that the deleted student is added back to the list.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I disagree with the team's response, as I feel that doing this will hamper the user experience greatly especially if they are working with a lot of students, when I executed the "undo" command I was expecting things to go back to the way they were earlier as that is essentially what the purpose of an undo command is.

However, the app modified the list by changing the ordering of the students which is not what an undo command should do and this clearly would cause occasional inconvenience to some users.