radeon2525 / pe

0 stars 0 forks source link

Export command is exporting invalid classes #7

Open radeon2525 opened 2 months ago

radeon2525 commented 2 months ago

The export command is exporting any and all types of class, which are not even present in the student list. As you can see I only have people with class '1A' in my list. However it is exporting empty classes of all names.

image.png

This should be fixed, since an administrator can make a mistake an input a class name that doesn't exist, this can cause the database to get cluttered up with empty csv files which can be a big problem for the organization.

image.png

Instead the app should raise an error for random class names which are not associated with any student in the list.

nus-se-script commented 2 months ago

Team's Response

Reason

As of v1.4, the files exported are not supposed to be purely based upon "class" or anything. For instance, a list containing students from 2 classes can be exported as 1 csv file if the teacher desires. Which class should this exported list be associated with then? This is a potential feature flaw that can be improved upon in the future, but is not in scope for v1.4. As of now, teachers can name the file they are exporting anything they want and we consider it to be too restrictive if we just limit it to the names of classes.

This feature behaves according to the specification provided in the user guide.

Reasons for severity change

Teachers are still able to export lists as any name they want. We conclude that a reasonable user will name their export filename according to its contents. (For instance, there's no particular reason a teacher would name a csv file containing students of Class 3A, "Class 3B".

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I disagree with the reason for severity change, as it is the job of the developer team to warn the user when they are making a mistake instead of assuming that the user will always input commands perfectly. Since this is a manual data entry job, thus when inputting the class name, the teacher can input Class 3A and "Classs 3A" or anything else. The onus is on the developer team to make sure this is prevented. Since if the teacher accidently inputs the incorrect class name, then it will be a big issue when trying to locate this file in the future as she will have to go through all of the files manually in the database.