radgrad / radgrad2

Source code for RadGrad, Version 2
https://radgrad.org
9 stars 5 forks source link

Change the way RadGrad imports InternAloha internships. #811

Closed cammoore closed 2 years ago

cammoore commented 2 years ago

Please do work for this task in a branch called issue-811.

We want at least one internship per interest.

We also want to limit the number of internships to some reasonably small number. The number could be set in the settings.json file.

Publish and subscribe to the smaller InternshipCollection.

Apply the interests to the internship, update the map of interests to internships. Pull the first internship for each interest. Then get to N by adding the internships with the most interests.

cammoore commented 2 years ago

Have initial version. I'm closing this issue, but we might want to reopen it later.

The current solution doesn't report interests w/o internships. That would be a nice feature to add.

cammoore commented 2 years ago

Going to reopen this to add the functionality from the Discord discussion.

(1) Provide a switch for the import process that deletes the collection prior to import. So, everything starts from scratch. That's probably useful right now while we're figuring out how to do things.

(2) internshipCountLimit applies to both the import process and the publication process. That way, if we discover the limit is too high, we can redeploy and get the benefits immediately without having to do a re-import. Or, we could have two settings by making internshipCountLimit into an object with two fields. For example: internshipCountLimit: { "import": 500, "publication": 200 }

cammoore commented 2 years ago

Getting duplicate URLs when we collapse the internships. Need to make sure they are unique.