search

radiac / django-tagulous

Fabulous Tagging for Django
http://radiac.net/projects/django-tagulous/
Other
336 stars 66 forks source link

Fixes #144 by inspecting args, kwargs #149

Closed nschlemm closed 2 years ago

nschlemm commented 2 years ago

This broke admin autocomplete for us when the tags are in the search_fields of the tagged model. Added a simple test.

nschlemm commented 2 years ago

@radiac can you please give a quick feedback here or on #144 ? THX!

codecov-commenter commented 2 years ago

Codecov Report

Merging #149 (250b88c) into develop (2179096) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #149   +/-   ##
========================================
  Coverage    99.50%   99.50%           
========================================
  Files           27       27           
  Lines         1812     1815    +3     
========================================
+ Hits          1803     1806    +3     
  Misses           9        9
Impacted Files Coverage Δ
tagulous/models/tagged.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2179096...250b88c. Read the comment docs.

radiac commented 2 years ago

Thank you for this - my apologies for the delay getting it merged. Released as 1.3.1.

nschlemm commented 2 years ago

@radiac no worries - I can totally relate and thanks!