radiac / django-tagulous

Fabulous Tagging for Django
http://radiac.net/projects/django-tagulous/
Other
336 stars 66 forks source link

Bugfix #164 Broken admin with Django 4.0 #167

Closed jedie closed 1 month ago

jedie commented 2 years ago

In Django 4.0 the AutocompleteMixin has been changed and the old AutocompleteMixin.media.fget(None) will raise an (silent) error.

Fix this and add a test to check the included JS files.

Normally, the whole thing should be tested via browser. But hopefully this way an error will be noticed faster.

codecov-commenter commented 2 years ago

Codecov Report

Merging #167 (0211424) into develop (1617a62) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #167   +/-   ##
========================================
  Coverage    99.56%   99.56%           
========================================
  Files           28       28           
  Lines         1840     1844    +4     
========================================
+ Hits          1832     1836    +4     
  Misses           8        8           
Impacted Files Coverage Δ
tagulous/forms.py 98.61% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1617a62...0211424. Read the comment docs.

jedie commented 2 years ago

@radiac Seems that the CI setup is broken?!?

bskim45 commented 1 year ago

@radiac can you help us out?

jedie commented 1 year ago

@radiac Any news here?

jedie commented 1 year ago

@radiac is this project dead?

radiac commented 1 year ago

It's not, I've just had a lot going on and a couple of other projects have had priority. Planning on getting back to this soon.

Thomas-Boi commented 9 months ago

Hi @radiac , I know that you have other things going on. However, it'd mean a lot if you can come back to this project. This library is excellent and I really want to use it with Django 4.2. The only thing preventing me from doing so is the broken autocomplete.

Appreciate everything you've done and would love to see this fix gets in.

radiac commented 1 month ago

Thanks so much for this patch, and once again my apologies for the outrageous delay getting to it!