search

radiac / django-tagulous

Fabulous Tagging for Django
http://radiac.net/projects/django-tagulous/
Other
332 stars 65 forks source link

tagulous.admin.enhance() will change the list_display to a list #183

Open jedie opened 7 months ago

jedie commented 7 months ago

Think it's a bad idea to change the "list_display" of a ModelAdmin class to a list, because it's mutable and this may result in side effects.

radiac commented 7 months ago

That's a fair point. I'm not sure how much real world risk with it, but may as well address it in the next release. There's potential that someone could now expect it to be a list, but that'd be reasonably simple for them to change as long as it's listed in the upgrade notes.

jedie commented 3 months ago

Same for get_autocomplete_fields() ;)