search

radian-software / apheleia

🌷 Run code formatter on buffer contents without moving point, using RCS patches and dynamic programming.
MIT License
523 stars 74 forks source link

Add support for `dprint` #249

Closed scop closed 7 months ago

scop commented 8 months ago

https://dprint.dev

raxod502 commented 8 months ago

This might need one or two more changes on my part, I think the rename-buffer call is also in the wrong context, and we should be hoisting the creation of the temporary input file to the beginning and not having it show up in both conditional branches. The entire test should probably be run in the context of the input temporary file, it was confusing me greatly that that was not the case.

scop commented 7 months ago

Thanks for the fixes! Merged main and updated the typescript plugin, tests pass now. Is there more things you'd like to see addressed or could we start looking into perhaps merging this?

raxod502 commented 7 months ago

Let's merge and fix forward