radian-software / apheleia

🌷 Run code formatter on buffer contents without moving point, using RCS patches and dynamic programming.
MIT License
517 stars 73 forks source link

Add support for dhall format #284

Closed zzantares closed 3 months ago

zzantares commented 5 months ago

Adds a new formatter dhall-format used for dhall.

raxod502 commented 4 months ago

Hmmm, if this formatter can automatically delete code comments, I am not sure we should enable it by default...

raxod502 commented 4 months ago

Is it supposed to be nondestructive and this is a bug? Or is it illegal to put comments in the place where there is one in your example?

zzantares commented 4 months ago

good catch, it seems this is a bug that has been reported upstream: https://github.com/dhall-lang/dhall-lang/issues/1275.

raxod502 commented 3 months ago

OK, we can add support for the formatter, but not enable it by default, since it has this destructive behavior.